[Settings] Settings UX enhancements #12912
Conversation
|
@jaimecbernardo @dedavis6797 would be great to get this one in before v0.45 |
|
|
Should the
|
|
For |
This comment has been minimized.
This comment has been minimized.
|
@seraphimaz as @Jay-o-Way pointed out, I forgot push a commit changing the severity level. The ready to install banner will stay as is! |
Holding out for now.. it might introduce language complexities for languages that have a different grammatical build up of the sentence.
InfoBadges normally do not provide tooltips (see WinUI spec). Clicking on it will show open the expander and show the message. I don't see the value of showing it twice, plus we'd need to make it keyboard accessible as well. |
But this is an informative message because the update isn't finished at this time. I think we should have/think like this: Ready (information) => Installing (information) => Up to date (success) |
|
I can confirm it's blue after the latest commit:
And then green:
|
|
@niels9001 , |
Summary of the Pull Request
#12867 - Changed Severity to Normal, but added blue highlight color so it stands out better.
Before:
After:
#12865 - Added an icon that shows that there's an error without expanding the plug-in settings. We can replace this later on with a InfoBadge whenever we upgrade to WinUI 2.7.
#12874 - Added a border around the app name
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.